Add stylelint plugin link and global command #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgengler
approved these changes
Feb 10, 2020
sgengler
left a comment
sgengler
left a comment
There was a problem hiding this comment.
@srayeskyo3 looks great! One suggestion for a possible addition as well.
Comment on lines
+949
to
+953
| You may have to install stylelint globally: | ||
| ``` | ||
| npm install stylelint -g | ||
| ``` | ||
|
|
There was a problem hiding this comment.
@srayeskyo3 yes I think this is a good note as this will confuse people
Additionally, instead of installing globally you can also add a script in package.json to run it as well, like:
"scripts": {
"styelint": "stylelint foo/**/*.scss'",
...
}
then run with npm run stylelint or yarn stylelint
would probably be good to add a note for that as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 things that I had to do, might be useful to add to the readme